This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
Fixing issue #499 #502
Merged
Fixing issue #499 #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prior to version 1.4.1 the output of a macro could be assigned to a variable with "set" - this restores that bahavior.
| @@ -31,4 +31,8 @@ describe('Tag: macro', function () { | |||
| it('gh-457: local context is copied and overwritten within macro context', function () { | |||
| expect(swig.render('{% set foo = 1 %}{% set baz = 3 %}{% macro bar(foo) %}{{ foo }}{{ baz }}{% endmacro %}{{ bar(2) }}{{ foo }}')).to.equal('231'); | |||
| }); | |||
|
|
|||
| it('a macro can be set to a variable', function () { | |||
There was a problem hiding this comment.
Awesome! Mind prepending the testcase with gh-499: before this is merged?
There was a problem hiding this comment.
Sure thing, this should now be part of this PR.
paularmstrong
added a commit
that referenced
this pull request
Jul 29, 2014
Allow macro output to be assigned via `set` tag. Fixes gh-499
|
Thanks @logie17! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with "set" - this restores that bahavior.